Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some tests for bar #1328

Merged
merged 9 commits into from
Apr 29, 2019
Merged

Add some tests for bar #1328

merged 9 commits into from
Apr 29, 2019

Conversation

sarahd93
Copy link
Contributor

Checklist:

@sarahd93 sarahd93 marked this pull request as ready for review April 26, 2019 14:41
@sarahd93 sarahd93 requested a review from a team April 26, 2019 14:41
@codecov
Copy link

codecov bot commented Apr 26, 2019 •
edited
Loading

Codecov Report

Merging #1328 into gsa-8.0 will increase coverage by 0.3%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           gsa-8.0    #1328     +/-   ##
==========================================
+ Coverage    34.43%   34.74%   +0.3%     
==========================================
  Files          959      959             
  Lines        21595    21597      +2     
  Branches      5977     5978      +1     
==========================================
+ Hits          7437     7503     +66     
+ Misses       12803    12753     -50     
+ Partials      1355     1341     -14
Impacted Files Coverage Δ
gsa/src/web/components/bar/progressbar.js 100% <100%> (+30.43%) ⬆️
gsa/src/web/utils/severity.js 72.97% <0%> (+21.62%) ⬆️
gsa/src/web/components/bar/statusbar.js 87.17% <0%> (+25.64%) ⬆️
gsa/src/web/components/bar/titlebar.js 77.27% <0%> (+40.9%) ⬆️
gsa/src/web/components/bar/toolbar.js 100% <0%> (+50%) ⬆️
...sa/src/web/components/provider/iconsizeprovider.js 88.88% <0%> (+66.66%) ⬆️
gsa/src/web/components/bar/severitybar.js 89.47% <0%> (+78.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7da296...c370529. Read the comment docs.

bjoernricks
bjoernricks suggested changes Apr 27, 2019
View reviewed changes
Copy link
Contributor

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only the changelog entry should be updated and some additional tests could be added.

CHANGELOG.md Outdated Show resolved Hide resolved
gsa/src/web/components/bar/__tests__/progressbar.js Show resolved Hide resolved
gsa/src/web/components/bar/__tests__/severitybar.js Show resolved Hide resolved
gsa/src/web/components/bar/__tests__/statusbar.js Show resolved Hide resolved
gsa/src/web/components/bar/__tests__/titlebar.js Show resolved Hide resolved
gsa/src/web/components/bar/__tests__/titlebar.js Show resolved Hide resolved
@bjoernricks @sarahd93
Update CHANGELOG.md
10058fc 
Co-Authored-By: sarahd93 <[email protected]>
@bjoernricks
Update CHANGELOG.md
c370529 
Remove duplicate entry
@bjoernricks bjoernricks merged commit 50cdc83 into greenbone:gsa-8.0 Apr 29, 2019
@sarahd93 sarahd93 deleted the bar_component_tests_gsa8 branch April 29, 2019 14:57
@arunkumaruniqueoutlook arunkumaruniqueoutlook mentioned this pull request Mar 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoernricks bjoernricks bjoernricks approved these changes

@swaterkamp swaterkamp Awaiting requested review from swaterkamp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sarahd93 @bjoernricks